[APIE-1040] Default flink statement --wait-timeout to 1m (defer 6h to next major)#3393
Merged
Daniel Ayaz (danielayaz) merged 1 commit intoJun 30, 2026
Conversation
Per review on the --wait reapply: keep the flink statement create --wait-timeout default at 1 minute, matching the pre-framework behavior (a hardcoded retry.Retry(time.Second, time.Minute, ...) poll). Jumping straight to 6h could surprise customers who script around the existing 1-minute timer, so defer the 6h bump to the next major version. Users can already lengthen the wait now via --wait-timeout. Updated the four flink statement create help goldens (default 6h0m0s -> 1m0s); verified the rendered --help matches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
Steven Gagniere (sgagniere)
approved these changes
Jun 29, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses review feedback on the
--waitreapply (#3389): keep theflink statement create--wait-timeoutdefault at 1 minute instead of jumping to 6h.The pre-framework
--waitused a hardcodedretry.Retry(time.Second, time.Minute, …)— a 1-minute timeout. Customers may have scripted around that timer, so silently changing the default to 6h on the--waitrefactor is a behavior change we'd rather not ship mid-cycle. This keeps the observable default identical to today and defers the 6h bump to the next major version (users who want longer can already pass--wait-timeout).One-line change to the constant + the four
flink statement createhelp goldens ((default 6h0m0s)→(default 1m0s)).Test plan
gofmtclean;go test ./internal/flink/passesconfluent flink statement create --helprenders--wait-timeout … (default 1m0s)(matches the regenerated golden)create-help,create-help-onprem,create-missing-compute-pool-failure,create-missing-sql-failure); no other6h0m0sreferences remainStacked on #3389 (
re-apply-wait-pr) — theflinkStatementCreateWaitTimeoutconstant only exists there, so this targets that branch; merging it folds the 1m default into the reapply before it lands onmain.🤖 Generated with Claude Code